[webkit-reviews] review granted: [Bug 219544] Add sandbox telemetry for likely unused features : [Attachment 415458] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 219544: Add sandbox telemetry for likely unused features
https://bugs.webkit.org/show_bug.cgi?id=219544

Attachment 415458: Patch

https://bugs.webkit.org/attachment.cgi?id=415458&action=review




--- Comment #3 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 415458
  --> https://bugs.webkit.org/attachment.cgi?id=415458
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415458&action=review

R=me.

>
Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:643
> +	  (with report) (with telemetry-backtrace)

Is a macOS version check needed here?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1297
> +    (with report) (with telemetry-backtrace)

This may need a macOS version check.