[webkit-reviews] review granted: [Bug 219553] Stop constructing unnecessary AudioBus in SincResampler : [Attachment 415455] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 4 14:31:58 PST 2020

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 219553: Stop constructing unnecessary AudioBus in SincResampler

Attachment 415455: Patch


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 415455
  --> https://bugs.webkit.org/attachment.cgi?id=415455

View in context: https://bugs.webkit.org/attachment.cgi?id=415455&action=review

> Source/WebCore/platform/audio/MultiChannelResampler.cpp:56
> +    void provideInputForChannel(float* buffer, size_t framesToProcess,
unsigned channelIndex)

Surprised that this function can just return and do nothing, with no indication
to the caller. But that’s not new.

More information about the webkit-reviews mailing list