[webkit-reviews] review denied: [Bug 219527] Align %TypedArray% constructor behavior with spec : [Attachment 415391] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 4 13:52:10 PST 2020


Yusuke Suzuki <ysuzuki at apple.com> has denied Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 219527: Align %TypedArray% constructor behavior with spec
https://bugs.webkit.org/show_bug.cgi?id=219527

Attachment 415391: Patch

https://bugs.webkit.org/attachment.cgi?id=415391&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 415391
  --> https://bugs.webkit.org/attachment.cgi?id=415391
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415391&action=review

Looks good! But I think we should have species optimization at the first patch
since new TypedArray(arrayBuffer) is common enough.

> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructorInlines.h:115
> +    JSValue constructor = source->get(globalObject,
vm.propertyNames->constructor);

Let's avoid doing property access by having watchpoint like Array / ArrayBuffer
are doing since `new TypedArray(arrayBuffer)` is enough critical path.
See speciesConstructArrayBuffer and speciesConstructArray.


More information about the webkit-reviews mailing list