[webkit-reviews] review granted: [Bug 219519] PCM: Switch to 8+4 bits for source IDs and trigger values respectively : [Attachment 415370] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 219519: PCM: Switch to 8+4 bits for source IDs and trigger values
respectively
https://bugs.webkit.org/show_bug.cgi?id=219519

Attachment 415370: Patch

https://bugs.webkit.org/attachment.cgi?id=415370&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 415370
  --> https://bugs.webkit.org/attachment.cgi?id=415370
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415370&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:77
> +    ASSERT_EQ(attribution.json()->toJSONString(),
"{\"source-engagement-type\":\"click\",\"source-site\":\"webkit.org\",\"source-
id\":255,\"attributed-on-site\":\"example.com\",\"trigger-data\":15,\"report-ve
rsion\":1}");

I wonder if this could be a formatted string so you wouldn't have to manually
replace the 63/63 with 255/15 if we have to change this again in the future.
Not critical for this patch.