[webkit-reviews] review granted: [Bug 219521] [GPUP] Move MediaCapabilities into the GPU process : [Attachment 415423] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 219521: [GPUP] Move MediaCapabilities into the GPU process
https://bugs.webkit.org/show_bug.cgi?id=219521

Attachment 415423: Patch

https://bugs.webkit.org/attachment.cgi?id=415423&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 415423
  --> https://bugs.webkit.org/attachment.cgi?id=415423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415423&action=review

> Source/WebCore/platform/MediaCapabilitiesDecodingInfo.h:65
> +    Optional<MediaCapabilitiesInfo> info =
MediaCapabilitiesInfo::decode(decoder);

Nit: `auto`

> Source/WebCore/platform/MediaCapabilitiesEncodingInfo.h:65
> +    Optional<MediaCapabilitiesInfo> info =
MediaCapabilitiesInfo::decode(decoder);

Ditto

> Source/WebCore/platform/mediacapabilities/MediaDecodingConfiguration.h:50
> +    Optional<MediaConfiguration> mediaConfiguration =
MediaConfiguration::decode(decoder);

Ditto.

> Source/WebCore/platform/mediacapabilities/MediaEncodingConfiguration.h:50
> +    Optional<MediaConfiguration> mediaConfiguration =
MediaConfiguration::decode(decoder);

Ditto.

> Source/WebCore/platform/mediacapabilities/VideoConfiguration.h:113
> +
> +

Nit: extra line