[webkit-reviews] review granted: [Bug 219007] [GPU Process] Clean up recreating the ImageBufferBackend because of GPU crashing : [Attachment 415395] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 219007: [GPU Process] Clean up recreating the ImageBufferBackend because of
GPU crashing
https://bugs.webkit.org/show_bug.cgi?id=219007

Attachment 415395: Patch

https://bugs.webkit.org/attachment.cgi?id=415395&action=review




--- Comment #18 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 415395
  --> https://bugs.webkit.org/attachment.cgi?id=415395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415395&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp:124
> +    auto backendSize = this->backendSize();

Doesn't seem worthwhile storing this in a local.

> Source/WebCore/platform/graphics/cg/ImageBufferCGBitmapBackend.cpp:108
> +    return {
static_cast<int>(CGBitmapContextGetWidth(context().platformContext())),
static_cast<int>(CGBitmapContextGetHeight(context().platformContext())) };

Let's not fetch context().platformContext() twice.