[webkit-reviews] review granted: [Bug 218934] [GPU Process] Share the NativeImage with GPU Process through a ShareableBitmap : [Attachment 415384] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 218934: [GPU Process] Share the NativeImage with GPU Process through a
ShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=218934

Attachment 415384: Patch

https://bugs.webkit.org/attachment.cgi?id=415384&action=review




--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 415384
  --> https://bugs.webkit.org/attachment.cgi?id=415384
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415384&action=review

> Source/WebKit/Shared/ShareableBitmap.h:133
> +    WebCore::PlatformImagePtr createPlatfromImage() { return
makeCGImageCopy(); }

Typo: platfrom. it's in a few places

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:-1103
> -void ArgumentCoder<Ref<NativeImage>>::encode(Encoder& encoder, const
Ref<NativeImage>& image)

I'm shocked this wasn't used for anything else, I thought for sure it predated
this project.