[webkit-reviews] review denied: [Bug 219505] Issue logging in to Microsoft Teams if logged into other Microsoft accounts and navigating directly to teams.microsoft.com : [Attachment 415331] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied  review:
Bug 219505: Issue logging in to Microsoft Teams if logged into other Microsoft
accounts and navigating directly to teams.microsoft.com
https://bugs.webkit.org/show_bug.cgi?id=219505

Attachment 415331: Patch

https://bugs.webkit.org/attachment.cgi?id=415331&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 415331
  --> https://bugs.webkit.org/attachment.cgi?id=415331
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415331&action=review

> Source/WebCore/ChangeLog:28
> +	   (WebCore::FrameLoader::receivedFirstData):

DocumentLoader::responseReceived might be a better place for this.

> Source/WebCore/page/Quirks.cpp:982
> +bool Quirks::isMicrosoftTeamsRedirectCase(const URL& url)

"Case" -> "URL"?

> Source/WebCore/page/Quirks.cpp:984
> +    return url.string().contains("teams.microsoft.com") &&
url.query().toString().contains("Retried+3+times+without+success");

Could we check the host instead of the whole url?  I'd rather not match
https://example.com/teams.microsoft.com?Retried+3+times+without+success

> Source/WebCore/page/Quirks.cpp:987
> +URL Quirks::microsoftTeamsRedirectURL()

I'm not sure this URL should be in Quirks.