[webkit-reviews] review granted: [Bug 219492] ASSERTION FAILED: isMainThread() in WTF::Optional<IntSize> &WebCore::surfaceMaximumSize() : [Attachment 415336] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 219492: ASSERTION FAILED: isMainThread() in WTF::Optional<IntSize>
&WebCore::surfaceMaximumSize()
https://bugs.webkit.org/show_bug.cgi?id=219492

Attachment 415336: Patch

https://bugs.webkit.org/attachment.cgi?id=415336&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 415336
  --> https://bugs.webkit.org/attachment.cgi?id=415336
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415336&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:253
> -    surfaceMaximumSize() = size;
> +    surfaceMaximumSize().store(size);

Can we assert that new size is not empty?

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:260
> +	   auto computedSize = computeMaximumSurfaceSize();

We should consider asserting that this won't happen when GPU process is enabled
and we're in the web content process using ProcessPrivilege.