[webkit-reviews] review granted: [Bug 219428] Add sandbox extension flag to specify that path contains no symlinks : [Attachment 415288] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 3 13:29:43 PST 2020


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 219428: Add sandbox extension flag to specify that path contains no
symlinks
https://bugs.webkit.org/show_bug.cgi?id=219428

Attachment 415288: Patch

https://bugs.webkit.org/attachment.cgi?id=415288&action=review




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 415288
  --> https://bugs.webkit.org/attachment.cgi?id=415288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415288&action=review

I reviewed this with Coops and I think it looks good. r=me.

> Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:277
> +    handle.m_sandboxExtension =
SandboxExtensionImpl::create(path.utf8().data(), type, WTF::nullopt, 
SandboxExtension::Flags::DoNotCanonicalize);

Extra whitespace before SandboxExtension::Flags::DoNotCanonicalize


More information about the webkit-reviews mailing list