[webkit-reviews] review granted: [Bug 219477] Fix for crash handling NSAccessibilityInsertionPointLineNumberAttribute for text fields in isolated tree mode. : [Attachment 415271] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 2 19:59:07 PST 2020


chris fleizach <cfleizach at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 219477: Fix for crash handling
NSAccessibilityInsertionPointLineNumberAttribute for text fields in isolated
tree mode.
https://bugs.webkit.org/show_bug.cgi?id=219477

Attachment 415271: Patch

https://bugs.webkit.org/attachment.cgi?id=415271&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 415271
  --> https://bugs.webkit.org/attachment.cgi?id=415271
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415271&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:-385
> -    unsigned selectionStart() const override { return 0; }

Can we remove the todo


More information about the webkit-reviews mailing list