[webkit-reviews] review granted: [Bug 219345] Move code from AxisScrollSnapOffsets to ScrollSnapOffsetsInfo : [Attachment 415013] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 2 19:34:56 PST 2020


Daniel Bates <dbates at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 219345: Move code from AxisScrollSnapOffsets to ScrollSnapOffsetsInfo
https://bugs.webkit.org/show_bug.cgi?id=219345

Attachment 415013: Patch

https://bugs.webkit.org/attachment.cgi?id=415013&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 415013
  --> https://bugs.webkit.org/attachment.cgi?id=415013
Patch

This patch looks good. I see a lot of opportunities to modernize the moved code
and use constexpr, range for-loops, etc etc. I think I've seen different code
styling for templates in other code.


More information about the webkit-reviews mailing list