[webkit-reviews] review granted: [Bug 219365] Create and draw app highlights : [Attachment 415183] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 219365: Create and draw app highlights
https://bugs.webkit.org/show_bug.cgi?id=219365

Attachment 415183: Patch

https://bugs.webkit.org/attachment.cgi?id=415183&action=review




--- Comment #19 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 415183
  --> https://bugs.webkit.org/attachment.cgi?id=415183
Patch

LGTM with the above comments, though I do agree that "builtin highlights" would
be more appropriate (we can tackle that in a followup, I suppose).

I think it would also be more ideal to make the builtin highlights registry
available everywhere, since that provides a generic mechanism for rendering
builtin (non-bindings-exposed) highlights, and then have the actual feature
flag guard the specific user-facing feature that this is being added to
support.