[webkit-reviews] review granted: [Bug 219305] Add support for overscroll-behavior parsing : [Attachment 415217] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted cathiechen
<cathiechen at igalia.com>'s request for review:
Bug 219305: Add support for overscroll-behavior parsing
https://bugs.webkit.org/show_bug.cgi?id=219305

Attachment 415217: Patch

https://bugs.webkit.org/attachment.cgi?id=415217&action=review




--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 415217
  --> https://bugs.webkit.org/attachment.cgi?id=415217
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415217&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2264
> +const Settings* CSSComputedStyleDeclaration::getSettings() const
> +{
> +    return &m_element->document().settings();
> +}

You don't appear to be using this. If you do use it, call it settings() (no
"get"), and have it return a reference.

> Source/WebCore/css/CSSStyleDeclaration.cpp:257
> +const Settings* CSSStyleDeclaration::getSettings() const

Just settings().

> Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl:279
> +    HRESULT overscrollBehaviorEnabled([ out, retval ] BOOL*);
> +    HRESULT setOverscrollBehaviorEnabled([in] BOOL enabled);

I don't think any of these Windows changes are necessary.