[webkit-reviews] review granted: [Bug 219189] Switch EWS workers for JSC-ARMv7-32bits build and test queues to a new machine. : [Attachment 414646] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 219189: Switch EWS workers for JSC-ARMv7-32bits build and test queues to a
new machine.
https://bugs.webkit.org/show_bug.cgi?id=219189

Attachment 414646: Patch

https://bugs.webkit.org/attachment.cgi?id=414646&action=review




--- Comment #7 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 414646
  --> https://bugs.webkit.org/attachment.cgi?id=414646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414646&action=review

> Tools/CISupport/ews-build/steps.py:1617
> +	       self.command.extend(['--no-testmasm', '--no-testair',
'--no-testb3', '--no-testdfg', '--no-testapi'])

what was the reason that igalia jsc-armv7 queue needed these parameters (e.g.:
--no-testmasm) earlier, and what's the reason it doesn't need it now?

> Tools/CISupport/ews-build/steps.py:1622
> +	       self.command.extend(['--memory-limited', '--verbose'])

why verbose?