[webkit-reviews] review granted: [Bug 219384] [WK1] Only the first wheel event in a gesture should be cancelable : [Attachment 415100] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 219384: [WK1] Only the first wheel event in a gesture should be cancelable
https://bugs.webkit.org/show_bug.cgi?id=219384

Attachment 415100: Patch

https://bugs.webkit.org/attachment.cgi?id=415100&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 415100
  --> https://bugs.webkit.org/attachment.cgi?id=415100
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415100&action=review

> LayoutTests/fast/events/wheel/first-wheel-event-cancelable.html:44
> +	       debug('Tests preventDefault on the first event results in the
rest of the events being cancelable')

description() would likely look better than debug().

> LayoutTests/fast/events/wheel/wheel-events-become-non-cancelable.html:55
> +	       debug('Tests that events in the gesture are non-cancelable if
preventDefault was not called on the first event');

ditto.