[webkit-reviews] review granted: [Bug 216017] <video> element prevents screen from sleeping even after playback finishes : [Attachment 407636] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 31 17:53:10 PDT 2020


Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 216017: <video> element prevents screen from sleeping even after playback
finishes
https://bugs.webkit.org/show_bug.cgi?id=216017

Attachment 407636: Patch

https://bugs.webkit.org/attachment.cgi?id=407636&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 407636
  --> https://bugs.webkit.org/attachment.cgi?id=407636
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407636&action=review

> Source/WebCore/ChangeLog:14
> +	   To address the problem, we now call updateSleepDisabling() when

This says updateSleepDisabling, which makes logical sense.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:3171
> +    rateChanged();

This says rateChanged, which makes less sense.


More information about the webkit-reviews mailing list