[webkit-reviews] review granted: [Bug 215844] WebGL goes in a bad state where glContext.createProgram() returns null : [Attachment 407518] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 215844: WebGL goes in a bad state where glContext.createProgram() returns
null
https://bugs.webkit.org/show_bug.cgi?id=215844

Attachment 407518: Patch

https://bugs.webkit.org/attachment.cgi?id=407518&action=review




--- Comment #10 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 407518
  --> https://bugs.webkit.org/attachment.cgi?id=407518
Patch

Great diagnosis, fix and test James!

One slight concern - if WebKit's WebGL conformance suite snapshot is rolled
forward again using the LayoutTests/webgl/generate-webgl-tests.py script, your
changes to
LayoutTests/webgl/2.0.0/resources/webgl_test_files/conformance/canvas/render-af
ter-resize-test.html will be overwritten, since that script simply copies the
files into the WebKit repository, ignoring whether any changes were made
locally.

Now, any future rolls of this test snapshot will likely be small, since it's
not under active development. Could you still think a little bit about this and
decide whether it's worth preventing accidents in this area? Thanks.