[webkit-reviews] review granted: [Bug 215994] Optimize the implementation of TransformationMatrix::rotate(double) : [Attachment 407580] For EWS

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 215994: Optimize the implementation of TransformationMatrix::rotate(double)
https://bugs.webkit.org/show_bug.cgi?id=215994

Attachment 407580: For EWS

https://bugs.webkit.org/attachment.cgi?id=407580&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 407580
  --> https://bugs.webkit.org/attachment.cgi?id=407580
For EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=407580&action=review

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:905
> +    multiply({ cosZ, sinZ, -sinZ, cosZ, 0, 0 });

I assume something extends this with the 1s in the diagonals to preserve the
other columns?