[webkit-reviews] review granted: [Bug 215992] EnabledBySetting extended attributes on a partial interface do not get merged with EnabledBySetting extended attributes on properties of that partial interface : [Attachment 407579] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 215992: EnabledBySetting extended attributes on a partial interface do not
get merged with EnabledBySetting extended attributes on properties of that
partial interface
https://bugs.webkit.org/show_bug.cgi?id=215992

Attachment 407579: Patch

https://bugs.webkit.org/attachment.cgi?id=407579&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 407579
  --> https://bugs.webkit.org/attachment.cgi?id=407579
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407579&action=review

>
Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.cpp:
5
> +    JSTestEnabledBySettingSupplemental.cpp at every build. This file must
not be tried to compile.

Not new or part of this patch, but just noticed:

1) We might want to reword "This file must not be tried to compile." since
that's not English.

2) If we don’t want people to compile something normally we’d put #error in it.