[webkit-reviews] review granted: [Bug 215983] Make Big5 encoder conform to the specification and behavior of Chrome and Firefox : [Attachment 407562] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 215983: Make Big5 encoder conform to the specification and behavior of
Chrome and Firefox
https://bugs.webkit.org/show_bug.cgi?id=215983

Attachment 407562: Patch

https://bugs.webkit.org/attachment.cgi?id=407562&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 407562
  --> https://bugs.webkit.org/attachment.cgi?id=407562
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407562&action=review

> Source/WebCore/platform/text/TextCodecICU.cpp:409
> +static Vector<uint8_t> eucJPEncode(StringView string, Function<void(UChar32,
Vector<uint8_t>&)> unencodableHandler)

Repeating what I said last time: These functions don’t belong in TextCodecICU.
The TextCodec architecture is designed to use separate TextCodec classes for
each type of encoding/decoding. This table-based encoding should be a new
class. I understand that we require it because of deficiencies in ICU but that
does not mean it should be in the ICU source file and class.

Please consider making that change.

> Source/WebCore/platform/text/TextCodecICU.cpp:416
> +	   UChar32 c = *iterator;

I prefer auto here.

> Source/WebCore/platform/text/TextCodecICU.cpp:464
> +	   UChar32 c = *iterator;

auto