[webkit-reviews] review granted: [Bug 215979] Rewrite main thread scroll latching logic : [Attachment 407554] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 215979: Rewrite main thread scroll latching logic
https://bugs.webkit.org/show_bug.cgi?id=215979

Attachment 407554: Patch

https://bugs.webkit.org/attachment.cgi?id=407554&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 407554
  --> https://bugs.webkit.org/attachment.cgi?id=407554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407554&action=review

> Source/WebCore/page/scrolling/ScrollLatchingController.cpp:55
> +// FIXME: This logic is different frmo ScrollingTreeLatchingController,
which simply lets the latching state elapse after 100ms.

frmo

> Source/WebCore/page/scrolling/ScrollLatchingController.cpp:186
> +    // We always allow the main frame receive wheel events to permit
rubber-banding.

Some grammar

> Source/WebCore/page/scrolling/ScrollLatchingController.h:75
> +	   Frame* frame { nullptr }; // Icky raw pointer. Use FrameIdentifier?

Did you want to fix this before landing?

> Source/WebCore/page/scrolling/ScrollingTreeLatchingController.cpp:40
>  static const Seconds resetLatchedStateTimeout { 100_ms };

Should we plop this in one place and use it from both?

> Source/WebCore/platform/PlatformWheelEvent.h:155
> +    bool isGestureContinuation() const; // The fingers-down part of the
gesture.

But not momentum?

> LayoutTests/ChangeLog:14
> +2020-08-18  Simon Fraser  <simon.fraser at apple.com>

Double changelog