[webkit-reviews] review granted: [Bug 215977] [JSC] `let [` sequence cannot appear in ExpressionStatement context : [Attachment 407538] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 215977: [JSC] `let [` sequence cannot appear in ExpressionStatement context
https://bugs.webkit.org/show_bug.cgi?id=215977

Attachment 407538: Patch

https://bugs.webkit.org/attachment.cgi?id=407538&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 407538
  --> https://bugs.webkit.org/attachment.cgi?id=407538
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407538&action=review

r=me. I'm shocked at how simple this patch is.

> Source/JavaScriptCore/parser/Parser.cpp:1964
> +	   failIfTrue(match(OPENBRACKET), "\"let [\" cannot appear at the
beginning of expression statement context");

This is fine as an explanation for a spec-aware individual, but I don't think
it's clear enough as a user-facing error message.
How about something like "cannot appear in a single-line control flow body"?