[webkit-reviews] review granted: [Bug 215901] Update PannerNode to support k-rate automation of its AudioParams : [Attachment 407516] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 215901: Update PannerNode to support k-rate automation of its AudioParams
https://bugs.webkit.org/show_bug.cgi?id=215901

Attachment 407516: Patch

https://bugs.webkit.org/attachment.cgi?id=407516&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 407516
  --> https://bugs.webkit.org/attachment.cgi?id=407516
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407516&action=review

> Source/WebCore/Modules/webaudio/AudioParam.cpp:277
> +	   for (unsigned i = 0; i < numberOfValues; ++i)

I suggest starting with 1 so we don’t do values[0] = values[0].

> Source/WebCore/Modules/webaudio/PannerNode.cpp:501
> +    double azimuth =
rad2deg(acos(std::clamp(projectedSource.dot(listenerRight), -1.0f, 1.0f)));

std::rad2deg, std::acos