[webkit-reviews] review denied: [Bug 215940] Web Inspector: Graphics: remove unnecessary main page check when iterating existing animations : [Attachment 407491] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 28 12:12:02 PDT 2020


Brian Burg <bburg at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 215940: Web Inspector: Graphics: remove unnecessary main page check when
iterating existing animations
https://bugs.webkit.org/show_bug.cgi?id=215940

Attachment 407491: Patch

https://bugs.webkit.org/attachment.cgi?id=407491&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 407491
  --> https://bugs.webkit.org/attachment.cgi?id=407491
Patch

LGTM, but it doesn't build.

Is there a behavior change? Does this mean iframe animations will show in the
main page? or that WebAnimation::instances() only returns such animations?


More information about the webkit-reviews mailing list