[webkit-reviews] review granted: [Bug 215867] Ensure that email notifications are not sent for obsolete and r- patches : [Attachment 407337] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 215867: Ensure that email notifications are not sent for obsolete and r-
patches
https://bugs.webkit.org/show_bug.cgi?id=215867

Attachment 407337: Patch

https://bugs.webkit.org/attachment.cgi?id=407337&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 407337
  --> https://bugs.webkit.org/attachment.cgi?id=407337
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407337&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:549
> +	       self._addToLog('stdio', 'Skipping email since patch {} is marked
r-'.format(patch_id))

Do we have a request somewhere to make this the behavior when a patch is marked
r-? It's not obviously that an r- ed patch shouldn't generate notification
emails.