[webkit-reviews] review granted: [Bug 215894] GetByVal constant folding over a Double OutOfBoundsSaneChain array with no BytecodeUsesAsOther should constant fold to PNaN, not undefined : [Attachment 407418] patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 215894: GetByVal constant folding over a Double OutOfBoundsSaneChain array
with no BytecodeUsesAsOther should constant fold to PNaN, not undefined
https://bugs.webkit.org/show_bug.cgi?id=215894

Attachment 407418: patch

https://bugs.webkit.org/attachment.cgi?id=407418&action=review




--- Comment #3 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 407418
  --> https://bugs.webkit.org/attachment.cgi?id=407418
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407418&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   BytecodeUsesAsOther return PNaN for holds and OOB accesses, not
jsUndefined().

Did you mean *holes*?