[webkit-reviews] review denied: [Bug 213016] [buildbot] Add buildAndTest bot for WebKitGTK (GTK4) : [Attachment 405356] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 27 07:07:11 PDT 2020


Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Diego Pino
<dpino at igalia.com>'s request for review:
Bug 213016: [buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
https://bugs.webkit.org/show_bug.cgi?id=213016

Attachment 405356: Patch

https://bugs.webkit.org/attachment.cgi?id=405356&action=review




--- Comment #4 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 405356
  --> https://bugs.webkit.org/attachment.cgi?id=405356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405356&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:89
> +		       { "name": "gtk-linux-bot-16", "platform": "gtk" },

Unfortunately I landed r266208 without realizing about this patch before.
And I already picked gtk-linux-bot-16 in r266208.
Can you please change the worker index number here to gtk-linux-bot-18 ?

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:354
> +			 "slavenames": ["gtk-linux-bot-16"]

Ditto


More information about the webkit-reviews mailing list