[webkit-reviews] review granted: [Bug 215068] [LFC][IFC] LineBuilder:Run should not have vertical geometry : [Attachment 407394] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 215068: [LFC][IFC] LineBuilder:Run should not have vertical geometry
https://bugs.webkit.org/show_bug.cgi?id=215068

Attachment 407394: Patch

https://bugs.webkit.org/attachment.cgi?id=407394&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 407394
  --> https://bugs.webkit.org/attachment.cgi?id=407394
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407394&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:178
> -	       // and the trimmed width should be capped at
std::min(run.trailingWhitespaceWidth(), overflowWidth) for texgt runs. Both FF
and Chrome agree.
> +	       // and the trimmed width should be capped at
std::min(run.trailingWhitespaceWidth(), overflowWidth) for text runs. Both FF
and Chrome agree.

Great spelling fixes!

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:394
> -    // Note that just becasue the trimmable width is 0 (font-size: 0px), it
does not mean we don't have a trimmable trailing content.
> +    // Note that just because the trimmable width is 0 (font-size: 0px), it
does not mean we don't have a trimmable trailing content.

Here too.

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:401
> -    // Do not add trimmable letter spacing after a fully trimmable
whitesapce.
> +    // Do not add trimmable letter spacing after a fully trimmable
whitespace.

And here.