[webkit-reviews] review granted: [Bug 215869] [macOS] Stop logging sandbox violations of com.apple.CoreDisplay.Notification : [Attachment 407353] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 215869: [macOS] Stop logging sandbox violations of
com.apple.CoreDisplay.Notification
https://bugs.webkit.org/show_bug.cgi?id=215869

Attachment 407353: Patch

https://bugs.webkit.org/attachment.cgi?id=407353&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 407353
  --> https://bugs.webkit.org/attachment.cgi?id=407353
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407353&action=review

>>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:771
>>> +#endif
>> 
>> But this is a new deny rule, not changing an existing one to no-log mode.
>> 
>> What am I missing?
> 
> Yes, you are right. There is no previous rule for this service, so the
default behavior is in effect, where the service is being denied, but with
logging enabled.
> 
> This change is only changing the logging behavior.
> 
> Thanks for reviewing!

Oh, didn’t realize that "deny" was default for everything. I guess that should
have been obvious.