[webkit-reviews] review granted: [Bug 215859] Make ImageDiff before TestWebKitAPI : [Attachment 407322] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 215859: Make ImageDiff before TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=215859

Attachment 407322: Patch

https://bugs.webkit.org/attachment.cgi?id=407322&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 407322
  --> https://bugs.webkit.org/attachment.cgi?id=407322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407322&action=review

> Tools/ChangeLog:3
> +	   Make ImageDiff before TestWebKitAPI

Given you are optimizing the sequence, why did you put it after MiniBrowser?

> Tools/Makefile:5
> +ifeq (,$(DO_NOT_BUILD_IMAGE_DIFF))
> +	MODULES += ImageDiff
> +endif

Would be nice to have a comment here, since it’s not obvious why we are adding
ImageDiff to the middle.