[webkit-reviews] review granted: [Bug 215828] Web Inspector: button for Inspector^2 doesn't work without setting default for DeveloperExtrasEnabled : [Attachment 407310] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 215828: Web Inspector: button for Inspector^2 doesn't work without setting
default for DeveloperExtrasEnabled
https://bugs.webkit.org/show_bug.cgi?id=215828

Attachment 407310: Patch

https://bugs.webkit.org/attachment.cgi?id=407310&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 407310
  --> https://bugs.webkit.org/attachment.cgi?id=407310
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407310&action=review

r=me, nice solution :)

> Source/WebInspectorUI/ChangeLog:11
> +	   Drive-by: because the Inspector^2 button is text-only and has no
> +	   .name element, the '2' button does not become dimmed when the
> +	   window is inactive, unlike every other item in the tab bar.
> +	   Fix this by coloring the text-only button similar to tab labels.

IMO, since this is an engineering only feature I don't think we need to care
about this ��

at the very least please put the styles in
Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css so it isn't shipped
(and maybe include a comment in UserInterface/Views/ButtonNavigationItem.css so
that we know there's some related styles elsewhere)