[webkit-reviews] review granted: [Bug 215798] [JSC] Add ASCII comparison fast path for IntlCollator : [Attachment 407261] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 215798: [JSC] Add ASCII comparison fast path for IntlCollator
https://bugs.webkit.org/show_bug.cgi?id=215798

Attachment 407261: Patch

https://bugs.webkit.org/attachment.cgi?id=407261&action=review




--- Comment #20 from Darin Adler <darin at apple.com> ---
Comment on attachment 407261
  --> https://bugs.webkit.org/attachment.cgi?id=407261
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407261&action=review

> Source/JavaScriptCore/runtime/IntlObjectInlines.h:125
> +    static_assert(UCOL_EQUAL == 0);
> +    static_assert(UCOL_GREATER == 1);
> +    static_assert(UCOL_LESS == -1);

Don’t need these any more.

> Source/JavaScriptCore/runtime/IntlObjectInlines.h:129
> +	   CharacterType1 lhs = characters1[position];
> +	   CharacterType2 rhs = characters2[position];

auto

> Source/JavaScriptCore/runtime/IntlObjectInlines.h:144
> +    return (length1 > length2) ? UCOL_GREATER : UCOL_LESS;

No parentheses needed here (match the weight if statement above).