[webkit-reviews] review granted: [Bug 215840] [JSC] Implement Intl.DateTimeFormat fractionalSecondDigits : [Attachment 407277] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 26 00:40:57 PDT 2020
Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 215840: [JSC] Implement Intl.DateTimeFormat fractionalSecondDigits
https://bugs.webkit.org/show_bug.cgi?id=215840
Attachment 407277: Patch
https://bugs.webkit.org/attachment.cgi?id=407277&action=review
--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 407277
--> https://bugs.webkit.org/attachment.cgi?id=407277
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=407277&action=review
Easy-peasy! :)
> Source/JavaScriptCore/builtins/DatePrototype.js:52
> + options.fractionalSecondDigits == @undefined
===, right?
> Source/JavaScriptCore/builtins/DatePrototype.js:168
> + options.fractionalSecondDigits == @undefined
Ditto.
> JSTests/stress/intl-datetimeformat.js:704
> + "fractionalSecondDigits",
nit: Indentation is off here (and also further above), though it doesn't matter
much in a test file.
More information about the webkit-reviews
mailing list