[webkit-reviews] review granted: [Bug 215822] Resource Load Statistics data summary does not report data which is held up in the web content process. : [Attachment 407220] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 215822: Resource Load Statistics data summary does not report data which is
held up in the web content process.
https://bugs.webkit.org/show_bug.cgi?id=215822

Attachment 407220: Patch

https://bugs.webkit.org/attachment.cgi?id=407220&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 407220
  --> https://bugs.webkit.org/attachment.cgi?id=407220
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407220&action=review

Looks good.

>
Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1447
> +    postTask([this, completionHandler = WTFMove(completionHandler)]()
mutable {

A very important fix! :-)

> Source/WebKit/WebProcess/WebProcess.cpp:1914
> +    completionHandler();

Does this completionHandler need to be synchronized with the
'updateCentralStatisticsStore'?