[webkit-reviews] review granted: [Bug 215825] [Mac, EME] Netflix.com shows HDCP error for all streams : [Attachment 407231] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 215825: [Mac,EME] Netflix.com shows HDCP error for all streams
https://bugs.webkit.org/show_bug.cgi?id=215825

Attachment 407231: Patch

https://bugs.webkit.org/attachment.cgi?id=407231&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 407231
  --> https://bugs.webkit.org/attachment.cgi?id=407231
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407231&action=review

> Source/WebCore/ChangeLog:11
> +	   displayID. This causes AVFoundation to do a "lowest common level  of
support" rather than a specific display check.

s/level  of support/level of support/

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreaming
AVFObjC.mm:1388
> +bool
CDMInstanceSessionFairPlayStreamingAVFObjC::keyRequestHasInsufficientProtection
ForDisplayID(AVContentKeyRequest  *request, PlatformDisplayID displayID) const

s/AVContentKeyRequest  *request/AVContentKeyRequest *request/

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreaming
AVFObjC.mm:1390
> +    // willOutputBeObscuredDueToInsufficientExternalProtectionForDisplays
will always return "YES" prior

s/return "YES" prior/return "YES" prior to/

>
Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreaming
AVFObjC.mm:1400
> +    // and to query the HDCP level required by each AVContentKeyRequest, and
do the comparison between th two in the

s/between th two/between the two/