[webkit-reviews] review canceled: [Bug 215760] Invalid early error for object literal method named "__proto__" : [Attachment 407179] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <shvaikalesh at gmail.com> has canceled Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 215760: Invalid early error for object literal method named "__proto__"
https://bugs.webkit.org/show_bug.cgi?id=215760

Attachment 407179: Patch

https://bugs.webkit.org/attachment.cgi?id=407179&action=review




--- Comment #4 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 407179
  --> https://bugs.webkit.org/attachment.cgi?id=407179
Patch

(In reply to Ross Kirsling from comment #2)
> r=me, this seems like a nice cleanup.

I appreciate you reviewing this, Ross! The diff is quite tough.

> nit: I'm not certain that a default param value is really better than a
> default field value here?

I've moved the default value to field initializer (TIL `struct` can also do
that), and brought back the `type` field.
PropertyNode::Type is the same size as `bool`, yet it's more useful to have
(unlike `name`).