[webkit-reviews] review granted: [Bug 215796] REGRESSION(r265601): invalid blame URL copied when `include_revision` is `false` : [Attachment 407172] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 215796: REGRESSION(r265601): invalid blame URL copied when
`include_revision` is `false`
https://bugs.webkit.org/show_bug.cgi?id=215796

Attachment 407172: Patch

https://bugs.webkit.org/attachment.cgi?id=407172&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 407172
  --> https://bugs.webkit.org/attachment.cgi?id=407172
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407172&action=review

> Tools/CopyPermalink/Sublime
Text/CopyWebKitPermalink/CopyWebKitPermalink.py:194
> +	   return 'https://trac.webkit.org/browser/{}/{}?{}{}{}'.format(branch,
path, revision, annotate_blame, line_number)

This doesn't look correct. Looks like ?&rev can be formed.