[webkit-reviews] review granted: [Bug 181714] Generated bindings for derived dictionaries are not regenerated when the base dictionary changes : [Attachment 407097] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 181714: Generated bindings for derived dictionaries are not regenerated
when the base dictionary changes
https://bugs.webkit.org/show_bug.cgi?id=181714

Attachment 407097: Patch

https://bugs.webkit.org/attachment.cgi?id=407097&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 407097
  --> https://bugs.webkit.org/attachment.cgi?id=407097
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407097&action=review

> Source/WebCore/bindings/scripts/preprocess-idls.pl:244
> +    my $makefileDeps = "#Supplemental dependencies\n";

Normally we’d have a space after the "#" in a comment.

> Source/WebCore/bindings/scripts/preprocess-idls.pl:258
> +    $makefileDeps .= "#Dictionaries dependencies\n";

Ditto.

> Source/WebCore/bindings/scripts/preprocess-idls.pl:261
> +	   my $dependencies = $dictionaryDependencies{$derivedDictionary};
> +	   $makefileDeps .= "JS${derivedDictionary}.cpp: ${dependencies}\n";

Not sure we benefit from the local variable here.