[webkit-reviews] review granted: [Bug 215681] Web Inspector: Elements: Styles: don't show swatches for properties that aren't used/apply : [Attachment 406903] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 215681: Web Inspector: Elements: Styles: don't show swatches for properties
that aren't used/apply
https://bugs.webkit.org/show_bug.cgi?id=215681

Attachment 406903: Patch

https://bugs.webkit.org/attachment.cgi?id=406903&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 406903
  --> https://bugs.webkit.org/attachment.cgi?id=406903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406903&action=review

r=me with a question.

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:466
> +	   if (this._property.enabled && !this._property.overridden &&
this._property.valid && !this._property.hasOtherVendorNameOrKeyword())

Do we support any hasOtherVendorNameOrKeyword properties that do not have an
unprefixed counterpart? This seems fine, unless it means some obscure --webkit-
properties no longer get swatches.