[webkit-reviews] review granted: [Bug 215760] Invalid early error for object literal method named "__proto__" : [Attachment 407084] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 215760: Invalid early error for object literal method named "__proto__"
https://bugs.webkit.org/show_bug.cgi?id=215760

Attachment 407084: Patch

https://bugs.webkit.org/attachment.cgi?id=407084&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 407084
  --> https://bugs.webkit.org/attachment.cgi?id=407084
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407084&action=review

r=me, this seems like a nice cleanup.

> Source/JavaScriptCore/parser/SyntaxChecker.h:107
> +	   ALWAYS_INLINE Property(PropertyNode::Type type, bool
isUnderscoreProtoSetter = false)

nit: I'm not certain that a default param value is really better than a default
field value here?