[webkit-reviews] review denied: [Bug 215642] [WebXR] Make "in parallel" code run really in parallel : [Attachment 406833] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied	review:
Bug 215642: [WebXR] Make "in parallel" code run really in parallel
https://bugs.webkit.org/show_bug.cgi?id=215642

Attachment 406833: Patch

https://bugs.webkit.org/attachment.cgi?id=406833&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 406833
  --> https://bugs.webkit.org/attachment.cgi?id=406833
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406833&action=review

> Source/WebCore/Modules/webxr/WebXRSession.cpp:198
>      // 2. Run the following steps in parallel:

When a spec says "in parallel", that does actually mean they have to be run on
separate threads, it's really just an event loop related hint that the steps
don't need to be run immediately in a specific order
(https://html.spec.whatwg.org/#in-parallel).

In WebCore, most of the DOM is not intended to be used from a non-main thread.