[webkit-reviews] review granted: [Bug 215647] Programmatic selection of text in a text field causes the highlight overlay to spill out : [Attachment 407080] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 215647: Programmatic selection of text in a text field causes the highlight
overlay to spill out
https://bugs.webkit.org/show_bug.cgi?id=215647

Attachment 407080: Patch

https://bugs.webkit.org/attachment.cgi?id=407080&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 407080
  --> https://bugs.webkit.org/attachment.cgi?id=407080
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407080&action=review

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:796
> +    auto selectionClipRect = [(UIView <UITextInputPrivate> *)contentView
_selectionClipRect];

Casting to a type with a protocol without checking if the view implements the
protocol seems peculiar. Normally we’d call respondsToProtocol in a case like
this. Alternatively we could assert that and comment why we know it’s true. Or
could leave it just like this if you prefer.