[webkit-reviews] review denied: [Bug 215646] The initial value of quotes should be auto. : [Attachment 407075] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 23 11:27:59 PDT 2020


Darin Adler <darin at apple.com> has denied Emilio Cobos Álvarez (:emilio)
<emilio at crisal.io>'s request for review:
Bug 215646: The initial value of quotes should be auto.
https://bugs.webkit.org/show_bug.cgi?id=215646

Attachment 407075: Patch

https://bugs.webkit.org/attachment.cgi?id=407075&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 407075
  --> https://bugs.webkit.org/attachment.cgi?id=407075
Patch

I did a grep, and all of these files have "quotes: ;" in them that have to be
changed to "quotes: auto;"

imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.
txt
platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csst
ext-expected.txt
platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-
csstext-expected.txt
platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csst
ext-expected.txt

So the patch needs to include changes to all 4 of the files. And they need to
be mentioned in the change log.


More information about the webkit-reviews mailing list