[webkit-reviews] review granted: [Bug 214406] [LFC][IFC] adjustBaselineAndLineHeight should take the parent inline box. : [Attachment 404527] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 22 10:42:38 PDT 2020


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 214406: [LFC][IFC] adjustBaselineAndLineHeight should take the parent
inline box.
https://bugs.webkit.org/show_bug.cgi?id=214406

Attachment 404527: Patch

https://bugs.webkit.org/attachment.cgi?id=404527&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 404527
  --> https://bugs.webkit.org/attachment.cgi?id=404527
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404527&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBuilder.h:227
> +    InlineBox m_lineBox;

Maybe the names should match?


More information about the webkit-reviews mailing list