[webkit-reviews] review granted: [Bug 215677] Move node geometry functions from Range to RenderObject : [Attachment 406962] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Darin Adler <darin at apple.com>'s request for
review:
Bug 215677: Move node geometry functions from Range to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=215677

Attachment 406962: Patch

https://bugs.webkit.org/attachment.cgi?id=406962&action=review




--- Comment #7 from zalan <zalan at apple.com> ---
Comment on attachment 406962
  --> https://bugs.webkit.org/attachment.cgi?id=406962
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406962&action=review

> Source/WebCore/rendering/RenderObject.h:573
> +    WEBCORE_EXPORT static Vector<FloatQuad> absoluteTextQuads(const
SimpleRange&, OptionSet<BoundingRectBehavior> = { });
> +    WEBCORE_EXPORT static Vector<IntRect> absoluteTextRects(const
SimpleRange&, OptionSet<BoundingRectBehavior> = { });
> +    WEBCORE_EXPORT static Vector<FloatRect> absoluteBorderAndTextRects(const
SimpleRange&, OptionSet<BoundingRectBehavior> = { });
> +    static Vector<FloatRect> clientBorderAndTextRects(const SimpleRange&);

It's a bit unfortunate that functions with _text_ and _border_	in their names
end up in RenderObject (where we have neither border nor text) but I understand
that it's hard to find a better place for a concept (Range) that has no
associated renderer.