[webkit-reviews] review granted: [Bug 215562] Resolve with the class used to define the Custom Element : [Attachment 406998] Implements the new behavior

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 215562: Resolve with the class used to define the Custom Element
https://bugs.webkit.org/show_bug.cgi?id=215562

Attachment 406998: Implements the new behavior

https://bugs.webkit.org/attachment.cgi?id=406998&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 406998
  --> https://bugs.webkit.org/attachment.cgi?id=406998
Implements the new behavior

View in context: https://bugs.webkit.org/attachment.cgi?id=406998&action=review

> Source/WebCore/bindings/js/JSDOMPromiseDeferred.h:80
> +	   JSC::JSGlobalObject* lexicalGlobalObject = globalObject();

auto

> Source/WebCore/dom/CustomElementRegistry.cpp:81
>      if (auto promise = m_promiseMap.take(localName))
> -	   promise.value()->resolve();
> +	   return WTFMove(*promise);
> +    return nullptr;

No if statement needed:

    return m_promiseMap.take(localName);