[webkit-reviews] review granted: [Bug 215720] Replace IC on Proxy must write barrier Proxy's target : [Attachment 406986] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 215720: Replace IC on Proxy must write barrier Proxy's target
https://bugs.webkit.org/show_bug.cgi?id=215720

Attachment 406986: patch

https://bugs.webkit.org/attachment.cgi?id=406986&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 406986
  --> https://bugs.webkit.org/attachment.cgi?id=406986
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406986&action=review

Nice, r=me

> Source/JavaScriptCore/bytecode/AccessCase.cpp:1798
> +	       jit.loadPtr(CCallHelpers::Address(baseGPR,
JSProxy::targetOffset()), scratchGPR);
> +	       auto spillState =
state.preserveLiveRegistersToStackForCallWithoutExceptions();
> +	      
jit.setupArguments<decltype(operationWriteBarrierSlowPath)>(CCallHelpers::Trust
edImmPtr(&vm), scratchGPR);
> +	       jit.prepareCallOperation(vm);
> +	       auto operationCall = jit.call(OperationPtrTag);
> +	       jit.addLinkTask([=] (LinkBuffer& linkBuffer) {
> +		   linkBuffer.link(operationCall,
FunctionPtr<OperationPtrTag>(operationWriteBarrierSlowPath));
> +	       });
> +	       state.restoreLiveRegistersFromStackForCall(spillState);
> +

Can you check whether AccessCase::doesCalls change is necessary?