[webkit-reviews] review granted: [Bug 215692] http/tests/websocket/tests/hybi/close-on-* tests are not interoperable : [Attachment 406921] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 215692: http/tests/websocket/tests/hybi/close-on-* tests are not
interoperable
https://bugs.webkit.org/show_bug.cgi?id=215692

Attachment 406921: Patch

https://bugs.webkit.org/attachment.cgi?id=406921&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 406921
  --> https://bugs.webkit.org/attachment.cgi?id=406921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406921&action=review

Seems OK but I have a big question.

> LayoutTests/ChangeLog:10
> +	   Before the patch, tests were not passing in Chrome, Firefox and
NSURLSession WebSocket code path.
> +	   This was due to the fact the web socket script is using try/finally
and the closure of the connection is not raising an exception
> +	   while it is for Chrome, Firefox and NSURLSession WebSocket code
path.

Why should we change our test to smooth over differences between WebSocket
implementations? Don’t we want to uncover such interoperability problems and
highlight them?

> LayoutTests/ChangeLog:11
> +	   Change the WebSocket server script to more reliablly send the socket
message at closing time of the connection.

typo: reliably