[webkit-reviews] review granted: [Bug 215687] [Cocoa] CTFontIsSystemUIFont() is faster than CTFontDescriptorIsSystemUIFont()/CTFontCopyFontDescriptor() : [Attachment 406916] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 215687: [Cocoa] CTFontIsSystemUIFont() is faster than
CTFontDescriptorIsSystemUIFont()/CTFontCopyFontDescriptor()
https://bugs.webkit.org/show_bug.cgi?id=215687

Attachment 406916: Patch

https://bugs.webkit.org/attachment.cgi?id=406916&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 406916
  --> https://bugs.webkit.org/attachment.cgi?id=406916
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406916&action=review

> Source/WTF/wtf/PlatformUse.h:310
> +#if PLATFORM(COCOA) && !(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <
110000)
> +#define USE_CTFONTISSYSTEMUIFONT 1
> +#endif

Is this a USE or a HAVE?

> Source/WebCore/platform/graphics/FontPlatformData.h:132
> +    static bool isSystemFont(CTFontRef);

Does this benefit from being a member function? Why not just a "free function"
in this file?